Restore snapshot using ceph rbd storage-pool

Helder_Ardachnikoff · October 8, 2024, 1:42pm

Hi folks,

I had been trying some features of incus storage pool with ceph, and I noticed a weird behavior related to snapshot restore.

I had running the following command:
incus storage volume snapshot restore ceph-pool

However I noticed that this command execute rbd snap rollback in background:

github.com

lxc/incus/blob/main/internal/server/storage/drivers/driver_ceph_volumes.go#L1809


      
          	if ourUnmount {
          		defer func() { _ = d.MountVolume(vol, op) }()
          	}
          
          	_, err = subprocess.RunCommand(
          		"rbd",
          		"--id", d.config["ceph.user.name"],
          		"--cluster", d.config["ceph.cluster_name"],
          		"--pool", d.config["ceph.osd.pool_name"],
          		"snap",
          		"rollback",
          		"--snap", fmt.Sprintf("snapshot_%s", snapshotName),
          		d.getRBDVolumeName(vol, "", false))
          	if err != nil {
          		return err
          	}
          
          	snapVol, err := vol.NewSnapshot(snapshotName)
          	if err != nil {
          		return err
          	}

Shouldn’t this command be named as rollback?
because it might be an misunderstood with the idea of .an restore snapshot feature create a clone to a new volume in ceph context.
Also, is there any feature to clone a snapshot to a new volume ?

Helder_Ardachnikoff · October 9, 2024, 5:36pm

never mind, I ended up figuring out, volume copy can handle with this feature