When using --import-into-incus flag for distobuilder, distrobuilder connects using the Incus socket

jarrodu · February 17, 2024, 1:57pm

I am running a Debian VM on my Incus host. I am using it to run distrobuilder.

The VM can connect to Incus using the incus-client package. I configured a remote that uses TLS.

When I use the --import-into-incus flag, distrobuilder tries to connect to incus using the local socket.

lxc/distrobuilder/blob/31117614484307037f0dfafeb95a2c3984f51535/distrobuilder/main_incus.go#L456


      
          	imageFile, rootfsFile, err := img.Build(c.flagType == "unified", c.flagCompression, c.flagVM)
          	if err != nil {
          		return fmt.Errorf("Failed to create Incus image: %w", err)
          	}
          
          	importFlag := cmd.Flags().Lookup("import-into-incus")
          
          	if importFlag.Changed {
          		path := ""
          
          		server, err := client.ConnectIncusUnix(path, nil)
          		if err != nil {
          			return fmt.Errorf("Failed to connect to Incus: %w", err)
          		}
          
          		image := api.ImagesPost{
          			Filename: imageFile,
          		}
          
          		imageType := "container"

It seems that it is not possible to add a proxy device on a VM to proxy sockets.

I am thinking either distrobuilder can be modified for this use-case or I need to rebuild my build server as an Incus container instead of a VM and proxy the socket.

For example, I could do something like what the Jenkins server does. I don’t understand the whole script, though.

github.com

lxc/lxc-ci/blob/main/bin/build-image-distrobuilder

#!/bin/sh -eu
export PATH="/snap/bin/:${PATH}"

cleanup() {
    set +e
    incus delete build-distrobuilder-cache -f >/dev/null 2>&1

    exit 0
}
trap cleanup EXIT HUP INT TERM

ARCH="$1"
TARGET="$2"
DISTRO="jammy"

# Create the container
incus init "images:ubuntu/${DISTRO}/${ARCH}" build-distrobuilder-cache \
    -c security.privileged=true -c security.nesting=true
printf "lxc.cgroup2.devices.allow = b 259:* rw\nlxc.cgroup.devices.allow = b 259:* rw" | incus config set build-distrobuilder-cache raw.lxc -

This file has been truncated. show original

Any other ideas? I guess I could just do some bash scripting and drop the --import-into-incus flag.

stgraber · February 17, 2024, 6:00pm

It shouldn’t be particularly difficult to make distrobuilder use shared/cliconfig to parse the same configuration file as the Incus CLI.

Alternatively you could also just do build-incus, then use incus image import to load the images into your Incus server. That’s basically what distrobuilder does through the API call.

jarrodu · February 17, 2024, 6:05pm

Yeah, the latter is what I ultimately did. It works, but I am still interested in making changes directly to distrobuilder.

I am not a go programmer, but I am starting to be able to read the code.